This will allow the user to specify searching the subject or body only or both. It also allows specifying the username in addition to the search criteria and not as an either/or option. <img src="/forum/images/icons/smile.gif" alt="" /><br /><br />This also provides the fix so that showflat.php and showthreaded.php display your multiple word search results all words are highlighted.<br /><br />There seemed to be an error for me in dosearch.php where the line<br /><br />if ($Searchpage 0) {<br /><br />is used.<br /><br />I had to change this to <br /><br />if ($Searchpage) {<br /><br />to make it work for me.<br /><br /><br />Give me some feedback on how this goes. It may need some adjusting. <img src="/forum/images/icons/wink.gif" alt="" />

seems to be working well here.. let me know if it looks like I did something wrong <img src="/forum/images/icons/smile.gif" alt="" /><br /><br />In dosearch, my file looks like this:<br /><br /> if ($Searchpage < 0) {<br /> $html -> not_right($ubbt_lang['NO_MORE'],$Cat);<br /> }

That's probably how it should look. <br /><br />I just looked again at my last download from the members area of ubbthreads-6-0-2.tar.gz and it does look like what I showed. Is your file from an earlier version?

I don't think so, tho I may have missed it in an earlier "upgrade" <img src="/forum/images/icons/crazy.gif" alt="" />

My ubbthreads-6-0-2.tar.gz says the same as AllenAyres:<br />[:"#666666"] <br /> if ($Searchpage < 0) {<br /> $html -> not_right($ubbt_lang['NO_MORE'],$Cat);<br /> } [/]

Now I'm going to have to go download it again. LoL I wonder how that can be? I looked at the file again and it does not have the < in it. <img src="/forum/images/icons/crazy.gif" alt="" />

That is odd. Thanks for the hack btw, works great <img src="/forum/images/icons/smile.gif" alt="" />

<blockquote><font class="small">posted by MTO:</font><hr /> My ubbthreads-6-0-2.tar.gz says the same as AllenAyres:<br />[:"#666666"] <br /> if ($Searchpage < 0) {<br /> $html -> not_right($ubbt_lang['NO_MORE'],$Cat);<br /> } [/] <hr /></blockquote><br /><br />I just downloaded it again and know what? Mine doesn't say that... LoL <img src="/forum/images/icons/crazy.gif" alt="" /><br /><br />Perhaps winzip is removing things? LoL I hope not.

do do do do ...<br /><br />sounds like the twilight zone <img src="/forum/images/icons/wink.gif" alt="" />

LoL yes it is rather bewildering... <img src="/forum/images/icons/wink.gif" alt="" />

Hmm, I'm getting some ugly SQL errors on 6.0.2 on win32...<br /><br />Check them out if you dare! LOL<br /><br />http://www.newoutriders.org/ubbtest/search.php

There needs to be a space on each side of the OR<br /><br />(B_Body LIKE '%dddd%')OR (B_Subject LIKE '%dddd%') )<br /><br />should be looking like this (of course if there are no errors you wont see this)<br /><br />(B_Body LIKE '%dddd%') OR (B_Subject LIKE '%dddd%') )<br /><br /><br />Hope that helps. <img src="/forum/images/icons/wink.gif" alt="" />

OK, I think I got the spacing fixed but I still get the error. I have a space in front of each AND and OR now in the code added to the dosearch.php

That is odd. Could you post your code and template changes? I'll see if I can spot what went wrong. <img src="/forum/images/icons/smile.gif" alt="" />

This patch will make the "Show all user's posts" link in the profiles work correctly.<br /><br />Above this line:<br /><br /> if (($Match == "Or") && ($Words)) {<br /><br />add this:<br /><br />if ($Match == "Username") {<br />$Match = "";<br />$ByUsername = $Words;<br />$Words = "";<br />}<br /><br /><br />I have attached the updated instructions. <img src="/forum/images/icons/smile.gif" alt="" />

small error<br /><br />Hi Dave,<br />Just installed this one, works great! Thanks.<br />A typo: you mention that in dosearch.php, you need to replace<br /> if ($Searchpage 0) {<br />with<br /> if ($Searchpage) {<br /><br />But it looks like in the latest version, the problem was fixed in the base code... and it looks like it should really be <br /><br />if ($Searchpage < 0) {<br /><br />Regards,<br />Max<br /><br /><br />

<blockquote><font class="small">posted by Max Fisch:</font><hr /> small error<br /><br />and it looks like it should really be <br /><br />if ($Searchpage < 0) {<br /><br />Regards,<br />Max<br /><hr /></blockquote><br /><br />Shhhhh-- <img src="/forum/images/icons/wink.gif" alt="" /> Dave can't see the [:"red"] < [/] and swears it isn't there. <img src="/forum/images/icons/laugh.gif" alt="" />

LoL this has been gone over in this thread. When I look at a fresh dosearch.php script right out of the .tar.gz file from the latest version release I have that error.<br /><br />Oddly enough, someone sent me a dosearch.php script that they could not make work with the hack and I noticed they had the same error.<br /><br />I have no idea why some have it (mostly me) and some dont. <img src="/forum/images/icons/crazy.gif" alt="" /><br /><br /><br />So if your dosearch.php doesn't match the line that needs changing you probably shouldn't change it. <img src="/forum/images/icons/wink.gif" alt="" />

<blockquote><font class="small">posted by Lisa_P:</font><hr /> <blockquote><font class="small">posted by Max Fisch:</font><hr /> small error<br /><br />and it looks like it should really be <br /><br />if ($Searchpage < 0) {<br /><br />Regards,<br />Max<br /><hr /></blockquote><br /><br />Shhhhh-- <img src="/forum/images/icons/wink.gif" alt="" /> Dave can't see the [:"red"] < [/] and swears it isn't there. <img src="/forum/images/icons/laugh.gif" alt="" /> <hr /></blockquote><br /><br /><br /><br />LoL @ Lisa<br /><br /><br />I swear!

Got it... but I was trying to say that if someone does need to change it, they should change it to " < 0 " as opposed to removing the 0 as your latest attached instructions state. <br /> <br />Cheers, <br />Max <br />

Yeah I thought of that after I uploaded it. I forgot that Allen had showed me what it should look like. LoL wish there was a way to edit attachments.<br /><br />Perhaps I'll fix that and then uploaded to the finished mods section.<br /><br />Not much else to do with this one. Is anyone else besides Aglavalin having problems with this hack on a windows box?<br />

<blockquote><font class="small">posted by JustDave:</font><hr /> This patch will make the "Show all user's posts" link in the profiles work correctly.<br /><br />Above this line:<br /><br /> if (($Match == "Or") && ($Words)) {<br /><br />add this:<br /><br />if ($Match == "Username") {<br />$Match = "";<br />$ByUsername = $Words;<br />$Words = "";<br />}<br /><br /><br />I have attached the updated instructions. <img src="/forum/images/icons/smile.gif" alt="" /> <hr /></blockquote><br /><br />Hey Dave, saw a new attachment in this post. Can we just use the patch you mentioned or is there something else new in the new attachment?

If your search is working then all you probably need is the patch. <img src="/forum/images/icons/smile.gif" alt="" />

great, patched up and working fine. <img src="/forum/images/icons/smile.gif" alt="" /> Thanks!

<blockquote><font class="small">posted by JustDave:</font><hr /> Yeah I thought of that after I uploaded it. I forgot that Allen had showed me what it should look like. LoL wish there was a way to edit attachments.<br /> <hr /></blockquote><br /><br />Check out scream's latest changes to 6.1, that's coming <img src="/forum/images/icons/wink.gif" alt="" /><br /><br />I think I may have found a buglet with this or in the base code. I was looking for a php editor and typed that in the search box and got this:<br />click me<br /><br />Seems it inserts a bold tag around every instance of php, even when it's a link to a smiley here, since /php/ is in the url <img src="/forum/images/icons/wink.gif" alt="" /> Someway to fix this? I thought rick had fixed it in the base code.

hmmmm perhaps adding a space before and after the word that is to be highlighted?<br /><br />In the showflat.php script try changing this:<br /><br /> $Body = @eregi_replace($searchwords[$x],"<b><i>".$searchwords[$x]."</i></b>",$Body);<br /> $Body = preg_replace("|(<a\s*[^>]+)<b><i>(\Q$searchwords[$i]\E)</i></b>([^>]*>)|i","\\1\\2\\3",$Body);<br /><br /><br />to this:<br /><br /> $Body = @eregi_replace(" $searchwords[$x] ","<b><i>".$searchwords[$x]."</i></b>",$Body);<br /> $Body = preg_replace("|(<a\s*[^>]+)<b><i>(\Q $searchwords[$i] \E)</i></b>([^>]*>)|i","\\1\\2\\3",$Body);<br /><br /><br />(I think that's how it would be... lol)<br /><br />showthreaded.php may be the same as well... <img src="/forum/images/icons/smile.gif" alt="" /><br />

I've added the possibility for users to search through their sent and received PM:s to this hack. Instead of selecting a forum to search for, an PM-option can be selected instead. There is also a quick search box added to the PM box on My Home.<br /><br />At the moment the code is a bit ugly, it works, but since the search is somewhat different for PM:s there is a lot of if statements. I don't really like that everything inside the loop that iterates through the search results is within an if statement and it does different things based on if the user searches the PM:s or the posts. I've also done an extra template for the PM:s search results. But I've used the normal search script because I didn't want to have two search pages and much of the code that builds the query is the same. <br /><br />If anyone is interested in this hack I'll try to clean it up a bit and make instructions for it.

There is still a bug. <br />I did Search for Username and typed my name. <br /> <br />I see more than one page. Good. <br />I click the forward button and I see not only my messages but tons of other messages too... <br /> <br />(You can try the search here at threadsdev.com and you see what I mean.) <br /> <br />Greetings

After this part of the hack code:<br /><br /><br /> if ($Match == "Username") {// profile "Show all user's posts" search link fix<br /> $Match = "";<br /> $ByUsername = $Words;<br /> $Words = "";<br /> }<br /><br /><br />add this:<br /><br /><br />$EByUsername = rawurlencode($ByUsername);<br /><br /><br /><br />And add the variables to the navigation links in the dosearch.tmpl file:<br /><br /><a href="{$config['phpurl']}/dosearch.php?Cat=$Cat&amp;Forum=$URLForum&amp;Words=$URLWords&amp;Match=$URLMatch&amp;Searchpage=$prevpage&amp;Limit=$Limit&amp;Old=$Old"><br /><br />and<br /><br /><a href="{$config['phpurl']}/dosearch.php?Cat=$Cat&amp;Forum=$URLForum&amp;Words=$URLWords&amp;Match=$URLMatch&amp;Searchpage=$nextpage&amp;Limit=$Limit&amp;Old=$Old"><br /><br /><br /><br />would be:<br /><br /><br /><br /><a href="{$config['phpurl']}/dosearch.php?Cat=$Cat&amp;ByUsername=$EByUsername&amp;Forum=$URLForum&amp;Words=$URLWords&amp;Match=$URLMatch&amp;Searchpage=$prevpage&amp;Limit=$Limit&amp;Old=$Old"><br /><br />and<br /><br /><a href="{$config['phpurl']}/dosearch.php?Cat=$Cat&amp;ByUsername=$EByUsername&amp;Forum=$URLForum&amp;Words=$URLWords&amp;Match=$URLMatch&amp;Searchpage=$nextpage&amp;Limit=$Limit&amp;Old=$Old"><br /><br /><br /><br />Not sure if this will work. Just guessing. <img src="/forum/images/icons/smile.gif" alt="" />

Hi Dave, <br />thank you very much for the fix!!! <br /> <br />I tested it: <br /> <br />*show all messages of other user (profile): ok <br />*show all messages of myself (profile): ok <br />*Seach for all posts of other username: ok <br />*Seach for all posts of myself: does not work <br /> (That means if I click: show next page 3 times here: ERROR) <br /> <br />UPDATE: I was too quick, for some reason now ALL seems to work. No idea what I did wrong, when testing!!!! <br /> <br />Anyone else see this too? <br />

Nope, all seems to work for me after adding the patch.

[]I've added the possibility for users to search through their sent and received PM:s<hr /></blockquote><br /><br />I'd LOVE to see this! <img src="/forum/images/icons/smile.gif" alt="" />

It's coming, it is finished, I just need to write the install instructions. I got sidetracked on fixing some bugs in threads and writing the BypassModeration mod. It will probably take a couple of days until it's ready though.

New to this version<br />I've added the possibility to search the Private Messages. I hope I've got all the instructions correct, but I'm not sure. Please let me know if it works. =]<br /><br />Mod Name / Version Searchpage Upgrade 3.0beta<br />Description This will add the option to search subject or body or both. Also, it allows for a seperate username field so searches can be done with specific criteria along with the username. It also allows for users to search through their sent and received Private Messages.<br />Working under UBB.threads 6.0.3<br />Any pre-requisites None<br />Author(s) Dave Lozier, Gardener<br />Credits Gardener for adding the PM-search.<br />Demo Not at the moment<br />Files Altered dosearch.tmpl, dosearch.php, myhome.tmpl, languages/dosearch.php<br />Database Altered No<br />New Files dosearch_PM.tmpl<br />Any other info This hack is heavily based on the Searchpage Upgrade 2.0 hack by Dave Lozier.<br />

What are the chances this will work if I install on 6.1b1 ?<br /><br />I just thought id ask before attempting it on a test board

I haven't seen the new code Gardener has added but from what I can remember there shouldn't be a problem with what I had added. Has anyone else got this running with 6.1 BR1 ?

And I haven't seen 6.1b1 yet so I can't really tell either. But if the original code works, this version has a good chance of working as well.

Yes, once again I had problems with this:<br /><br /><pre><font class="small">code:</font><hr><br />if ($Searchpage 0) {<br /> $html -> not_right($ubbt_lang['NO_MORE'],$Cat);<br />}<br /></pre><hr><br /><br />I know it should be this:<br /><br /><pre><font class="small">code:</font><hr><br />if ($Searchpage < 0) {<br /> $html -> not_right($ubbt_lang['NO_MORE'],$Cat);<br />}<br /></pre><hr><br /><br /><br />But while editing with Dreamweaver it kept removing the < for some strange reason.<br /><br />I ended up changing the file to a "text" file and then edited it and uploaded it and then changed the name back to a php file and it worked!!!<br /><br />Finally I know I'm not crazy. It was dreamweaver all the long... (I hope) <img src="/forum/images/graemlins/wink.gif" alt="" />

Is it just me or in dosearch.php......<br /><br />Shouldn't this:<br /><br />$prevlinkstart = "<a href=\"{$config['phpurl']}/dosearch.php?Cat=$Cat&amp;Forum=$URLForum&amp;Words=$URLWords&amp;Match=$URLMatch&amp;Searchpage=$prevpage&amp;Limit=$Limit&amp;Old=$Old\">";<br /><br />Be this:<br /><br />$prevlinkstart = "<a href=\"{$config['phpurl']}/dosearch.php?Cat=$Cat&amp;Forum=$URLForum&amp;Words=$URLWords&amp;Match=$URLMatch&amp;Searchpage=$prevpage&amp;Limit=$Limit&amp;Old=$Old&amp;ByUsername=$ByUsername\">";<br /><br />... and you would need to do the same for the $nextlinkstart

Yes you are correct. I believe I forgot to add that in here too. I had mentioned this change somewhere around here before but had forgotten about it. Thanks. <img src="/forum/images/graemlins/smile.gif" alt="" />

{$ubbt_lang['SEARCH_PM']} Seems to be used in search.tmpl but in the instructions it isn't mentioned as being added to language/search.php

I believe that was Gardener's addition to the search page upgrade. I haven't looked at the code myself but perhaps he can help on this one. <img src="/forum/images/graemlins/smile.gif" alt="" />

Yes, it seems that I missed the language string in search.pm in the instructions. Just add this line to search.pm:<br /><br />$ubbt_lang['SEARCH_PM'] = "Search your Private Messages";<br /><br />I'll update the instructions and repost.

3DSHROOM mentioned a slight problem with the search upgrade for 6.1.x which is fixed in this version as well as another thing related to it. I have also fixed some missing language strings and updated the instructions for 6.1.0.<br /><br />The new version is attached to this post.

Thanks Gardener! <img src="/forum/images/graemlins/cool.gif" alt="" /><br /><br />Warm regards<br /><br />Nikos

Glad to see I could help out...<br /><br />A suggestion... Make an option to search for "parent threads" (ie B_Parent=='0') or "threads and replies". It's usefull with larger boards when you need to cut down the number of duplicate matches.

That's a good idea, I'll look into it as soon as I have some spare time, but I won't promise anything.<br /><br />Another tip I got from one of my users was to add both start and end for the date range to limit the search even more.<br /><br />Does anyone else have any suggestions for the search page while I'm (possibly) at it?

How about using + and - on the search for the words. For instance +ubb +threads will show me every post that has ubb AND threads in it (body or subject) but +ubb -threads will show only the ones that have the ubb in them - ubbthreads will be ignored.<br /><br />I hope I have not opened pandora's box <img src="/forum/images/graemlins/wink.gif" alt="" /><br /><br />Warm regards<br /><br />Nikos

That would be a good idea, but writing a parser for that would be a bit harder. I'll keep it in mind though.

Any chance in getting this workable under 6.2? My users love this mod (as do I). It's kind of sad that this isn't an official feature. The default search is very basic.

Since I don't have access to the member area anymore I haven't even looked at any 6.2 code so I couldn't say. Maybe someone else could do the necessary changes. I agree with you that the extended search possibilities should be a standard feature.

>Since I don't have access to the member area anymore<br /><br />Why not?

He he.... it costs money. <img src="/forum/images/graemlins/smile.gif" alt="" />

Yup, it does, and I'm a poor student who can't afford it at the moment. =[

For as much work as you, JoshPet, and JustDave do on Threads, they should give you a free lifetime license <img src="/forum/images/graemlins/smile.gif" alt="" /> I was lucky enough to have a license before they were bought by Infopop, so I only have to pay a little over $30 a year <img src="/forum/images/graemlins/smile.gif" alt="" />

Yeah, me too, so it isn't that much money, but it's still a bit more than I can pay at the moment. I'll try to get the rest of the admins to help me pay it soon though, shouldn't be any problem.

Good to hear

Looks like the problem is solved, thanks to matts:<br />http://www.threadsdev.com/threads/php/showflat.php?Cat=&Board=finished&Number=64283